-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop prefix vk #7
Comments
That's a fair suggestion! There is value in having a 1:1 mapping of the C-API, but since we don't export any functions, it might be nicer to just drop the |
How about remove the At the first glance, the To me, this package serves as an one-to-one correspondence of the Vulkan C-API, I guess there is no harm in exporting everything out: ModernGL.jl exports every gl* function and GL* constant, and it works fine. Any abstraction should go into more high-level packages like Vulkan.jl. |
If you want no abstractions, you shouldn't use a package for the new functions. |
I agree with @Gnimuc. Personnally, I just use VulkanCore.vk directly, because typing in the vk. each time is annoying (especially for all those enums!). If one wants to keep it that way, then import VulkanCore
const vk = VulkanCore seems an acceptable solution to me. As for dropping the vk/Vk/VK_ prefix, I also believe that it would better be done inside Vulkan.jl. The main reason would be, in addition to being a 1:1 correspondence with the Vulkan API, that it is easier to define new symbols that don't have this prefix as a higher abstraction (e.g. to wrap a |
I think we agree that for such a core/low-level package, keeping the prefixes makes sense, so I'll close this. |
All variables starting with vk or VK_ that are already in package vk should be renamed.
vk.SUCCESS instead of vk.VK_SUCCESS and vk.createImage instead of vk.vkCreateImage etc.
The text was updated successfully, but these errors were encountered: