Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle complex datatype #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

handle complex datatype #57

wants to merge 2 commits into from

Conversation

nikopj
Copy link

@nikopj nikopj commented Jul 19, 2024

Addresses #56. Tests added for ComplexF64.

Feedback appreciated.

@avik-pal
Copy link
Contributor

@nikopj
Copy link
Author

nikopj commented Aug 1, 2024

Any idea what the test failures are? https://buildkite.com/julialang/nccl-dot-jl/builds/36#0190cca1-710b-4b33-96b5-39d1fc64a262/303-1126

This looks unrelated to the pull request to me... did a configuration for the tests change since the last successful PR?

@findmyway
Copy link

The failure is the same with #58 and should be fixed with JuliaGPU/CUDA.jl#2457

@nikopj
Copy link
Author

nikopj commented Aug 13, 2024

Can we retrigger the build test now that JuliaGPU/CUDA.jl#2457 is merged?

@avik-pal
Copy link
Contributor

do a force push to your branch, it will retrigger the build. I don't have permissions

@avik-pal
Copy link
Contributor

That patch hasn't been released yet, we will have to wait till it is released

@avik-pal
Copy link
Contributor

Maybe we should also bump CUDA version to that patch once it is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants