Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid constructing MulAddMuls #623

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Avoid constructing MulAddMuls #623

merged 2 commits into from
Oct 16, 2024

Conversation

dkarrasch
Copy link
Contributor

This is a companion PR to JuliaLang/julia#52439. Basically, it avoids the construction of MulAddMuls and simply passes the factors alpha and beta forward.

@dkarrasch dkarrasch marked this pull request as draft April 23, 2024 17:19
@amontoison
Copy link
Member

@dkarrasch, can you rebase your PR?
I started merging some modifications with #682 (merged) and #613 (not merged).
The PR contains additional dispatches that are not working, so this PR could help isolate what the issue is.

@dkarrasch
Copy link
Contributor Author

@dkarrasch, can you rebase your PR?

I finally got around to it.

@amontoison
Copy link
Member

Thanks @dkarrasch !

@amontoison amontoison marked this pull request as ready for review October 16, 2024 17:49
@amontoison amontoison merged commit e700433 into JuliaGPU:master Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkarrasch @amontoison