-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Face for end keyword #170
Comments
Technically it is feasible, but I guess most people prefer to have it match the openings |
I believe you are right. I think the majority would keep them with matching colors. But possibly users coming from Python and whose theme uses a showy color for keywords would like to partially hide the |
Similarly to my comment in the other issue, I have no objections to this in principle (we can always inherit a default from another face so existing setups are unaffected), but I would suggest waiting a bit for comments. |
Regarding this issue, besides asking about the possibility of implementing such a face now that some time has elapsed, I'd just like to add this fact I came across: atom already dims the |
A PR is welcome, but please default to current behavior. |
I'll make sure the current behaviour is the default one! |
I saw using to tree-sitter is being considered. That would refine font-locking, right? Should I hold back? |
Possibly, but we have no timeframe on #174. |
It would be nice to have a special face of the
end
keyword. One may wish to give it a discreet colour so that theend
's become more inconspicuous.The text was updated successfully, but these errors were encountered: