Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoupledSDEs not a CoreDynamicalSystem? #228

Open
oameye opened this issue Nov 22, 2024 · 1 comment · May be fixed by #229
Open

CoupledSDEs not a CoreDynamicalSystem? #228

oameye opened this issue Nov 22, 2024 · 1 comment · May be fixed by #229

Comments

@oameye
Copy link
Member

oameye commented Nov 22, 2024

f!(du, u, p, t) = du .= 1.01u # deterministic part
sde = CoupledSDEs(f!, zeros(2));
ode = CoupledODEs(sde)

jacobian(sde) # fails
jacobian(ode) # works

ode isa CoreDynamicalSystem # true
sde isa CoreDynamicalSystem # false
ode isa ContinuousTimeDynamicalSystem # true
sde isa ContinuousTimeDynamicalSystem # true

How come that CoupledSDEs is not CoreDynamicalSystem?

@Datseris
Copy link
Member

Why should it be? The only reason this supertype exists is for TangentDynamicalSystem.

@oameye oameye linked a pull request Nov 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants