Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use set_state! in lyapunov rescale! #289

Closed
wants to merge 2 commits into from
Closed

Use set_state! in lyapunov rescale! #289

wants to merge 2 commits into from

Conversation

xlxs4
Copy link

@xlxs4 xlxs4 commented Oct 17, 2022

Closes #213. From the issue:

we can do some optimization so that we have a dummy preinitialized r that we carry around and modify its value in place so that we don't create a new r all the time

Open to any pointers.

Tests pass locally:

image

@Datseris
Copy link
Member

Ah. also, there is an ongoing PR that tries to fix the same thing but turned out to be more complicated: #214

@Datseris
Copy link
Member

I'll have a look but I can't promise when (same thing with the #214 ) , because I have many projects going on :( But the code here looks like a simpler change so I think I'll get to this quickly enough!

@Datseris Datseris closed this Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Datseris Datseris Datseris left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-write source code of lyapunov to use set_state!
2 participants
@xlxs4 @Datseris