Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between the MFS of the BruteForce and BlackBox #156

Open
Datseris opened this issue Oct 7, 2024 · 0 comments
Open

Inconsistency between the MFS of the BruteForce and BlackBox #156

Datseris opened this issue Oct 7, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers high priority tipping Tipping points related stuff

Comments

@Datseris
Copy link
Member

Datseris commented Oct 7, 2024

Describe the bug

Our implementation of brute force and black box algorithms for the Minimal Fatal Shock are inconsistent. The BlackBox variant returns a vector that leads to a different attractor (as defined) while the Brute Force variant returns a vector that leads to the same attractor (NOT as defined). This is wrong and it is simply because of the logic of the for loop: the brute force version must return the second-to-last estimated vector, not the last one, as the last one leads to the same basin.

Minimal Working Example

One can use the example of the documentation and swap the two algorithms and then call the output with the given mapper.

@Datseris Datseris added bug Something isn't working tipping Tipping points related stuff high priority good first issue Good for newcomers labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers high priority tipping Tipping points related stuff
Projects
None yet
Development

No branches or pull requests

1 participant