Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Dataset explicitly #154

Closed
wants to merge 1 commit into from
Closed

Conversation

kahaaga
Copy link
Member

@kahaaga kahaaga commented Dec 1, 2021

Trying to locate the CI error (here) when constructing Datasets from time series.

The only test being run now is

using Test
x, y = rand(100), rand(100)
@test Dataset(x, y) isa Dataset

@kahaaga
Copy link
Member Author

kahaaga commented Dec 1, 2021

I guess simply assinging x = delay... and then @test x isa .... will solve it?

@Datseris In this test PR, I removed all tests from the package, and leave only one test:

using Test
x, y = rand(100), rand(100)
@test Dataset(x, y) isa Dataset

This works fine locally, but for some reason, is broken when running PR.

@kahaaga
Copy link
Member Author

kahaaga commented Dec 1, 2021

AH! I found the error. Julia 1.7 has officially been released.

In the ci.yml file in this repository, the following line specifies the version of Julia to run for CI.

 matrix:
        version:
          - '1' # Replace this with the minimum Julia version that your package supports. E.g. if your package requires Julia 1.5 or higher, change this to '1.5'.

According to julia-actions/setup-julia, version 1 will mean the latest available julia version. Since 8 hours ago, that is now julia 1.7. So it seems that the generated functions inDelayEmbeddings break when running on 1.7. This might have consequences for your other reposities too, @Datseris .

@kahaaga
Copy link
Member Author

kahaaga commented Dec 1, 2021

Solved with JuliaDynamics/DelayEmbeddings.jl#99

@kahaaga kahaaga closed this Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant