Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A general reminder that speed-ups are possible for many methods #344

Open
kahaaga opened this issue Oct 3, 2023 · 0 comments
Open

A general reminder that speed-ups are possible for many methods #344

kahaaga opened this issue Oct 3, 2023 · 0 comments

Comments

@kahaaga
Copy link
Member

kahaaga commented Oct 3, 2023

As mentioned in #341, independence testing can be very slow. The slow runtime is mostly due to intrinsic properties of the methods. However For example, in #341 it is mentioned that

For example, only with a timeseries of length 3,000, the LocalPermutationTest with 50 shuffles takes quite a while.

The reason this is so slow is because LocalPermutationTest uses repeated nearest neighbor searches. In general, there is a huge potential for speed-ups both here and in ComplexityMeasures.jl for the kNN-based methods. Potential avenues for improvements are approximate kNN searches, and implementing in-place neighbor searches, so that we can re-use memory when re-searching for neighbors for surrogate realizations.

kahaaga added a commit that referenced this issue Oct 3, 2023
kahaaga added a commit that referenced this issue Oct 4, 2023
…ing dedicated TE estimators (#350)

* Fix issue #348

* More effective estimation for `Lindner` when doing e.g. surrogate tests

partially addresses #344

* Typos

* Add tests

* Up patch version

* Correctly scale

* Make sure we have enough samples for tests

* Better test organization

* It is the estimator that controls what happens, not the measure

* Add note to `LocalPermutationTest` docstring about transfer entropy

* Error should occur only for `TransferEntropyEstimator`s

* More tests

* Improve test comments.

* Fix #349

And also mention conditioning in `Zhu1` docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants