Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to the agents.jl file #966

Open
Datseris opened this issue Feb 3, 2024 · 0 comments
Open

Add comments to the agents.jl file #966

Datseris opened this issue Feb 3, 2024 · 0 comments
Assignees
Labels
clarity Regardig clarity of source code (not docs)

Comments

@Datseris
Copy link
Member

Datseris commented Feb 3, 2024

The agents.jl file is now very complex. It has macros and other non trivial things like

const __AGENT_GENERATOR__ = Dict{Symbol, Expr}()

which I don't even remember why we put it there...

Yet the file has practically no comments to guide the reader.

We should add plenty of comments, that explain all non-trivial lines of code. Most lines of code are non-trivial. E.g., what does

    @capture(new_type, _{new_params__})

do? I would say almost everything relate to macros is non-trivial.

Unfortunately, @Tortar I think you are the only one that can solve this issue, so it would be fantastic if you took an hour at some point and added a PR with comments that clarify the source code.

@Datseris Datseris added the clarity Regardig clarity of source code (not docs) label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarity Regardig clarity of source code (not docs)
Projects
None yet
Development

No branches or pull requests

2 participants