Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems with getNString #35

Open
ExpandingMan opened this issue Jan 10, 2018 · 0 comments
Open

problems with getNString #35

ExpandingMan opened this issue Jan 10, 2018 · 0 comments

Comments

@ExpandingMan
Copy link
Collaborator

ExpandingMan commented Jan 10, 2018

Some drivers (in my case presto) appear to not support getNString. In such cases, getString seems to work just fine. The problem this presents us with is how to choose which function to use (this matters for the vast majority of cases which are automated such as dumping into DataFrames). Note that right now these functions are looked up in a Dict depending on their JDBC type code.

I actually don't seem to have anywhere where I can test getString on drivers which support getNString (I'm not entirely sure what those are anyway).

Any thoughts on this? Can anyone check if getString works for them in place of getNString? It would be really nice if we can just get rid of getNString. Error catching would be waaaay too slow here.

The only other alternative I could see would be to create a function that changes the Dict appropriately on user command. This is inelegant and entrenches an existing efficiency problem, but should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant