Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method ambiguities reported by Aqua #90

Closed
prbzrg opened this issue Dec 27, 2023 · 2 comments
Closed

Method ambiguities reported by Aqua #90

prbzrg opened this issue Dec 27, 2023 · 2 comments

Comments

@prbzrg
Copy link

prbzrg commented Dec 27, 2023

In Julia v1.10, I used Aqua to detect method ambiguities in my package impICNF/ContinuousNormalizingFlows.jl#356 and some of its report were related to this package:

Ambiguity #105
sort!(vs::AbstractVector{T}, lo::Int64, hi::Int64, ::SortingAlgorithms.RadixSortAlg, o::Base.Order.Ordering, ts::Union{Nothing, AbstractVector{T}}) where T @ SortingAlgorithms ~/.julia/packages/SortingAlgorithms/3sO8j/src/SortingAlgorithms.jl:582
sort!(v::AbstractVector, lo::Integer, hi::Integer, a::Base.Sort.Algorithm, o::Base.Order.Ordering, scratch::Vector) @ Base.Sort sort.jl:2209

Possible fix, define
  sort!(::AbstractVector{T}, ::Int64, ::Int64, ::SortingAlgorithms.RadixSortAlg, ::Base.Order.Ordering, ::Vector{T}) where T

I would appreciate your attention to this issue.

@LilithHafner
Copy link
Member

Thank you for reporting. This was fixed in #80 but I haven't released it yet because the ambiguity does not effect users of this package's public API or Base's public API. It could be considered either bad API design or an Aqua false positive, either way it's easy to fix and has been fixed. I will release 1.2.1 with the fix for this presently.

@LilithHafner
Copy link
Member

Should be fixed in the latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants