Make it possible to evaluate package loadability. #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
changed the title
|
Example report: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/e0656ac/report.html This will need some additional fixes across the PkgEval stack to ensure @KristofferC Thoughts on this change? It was motivated by having additional coverage on loadability of packages when they're blacklisted because of test failures, but we'll need to be careful that it's clearly shown as such. |
maleadt
force-pushed
the
tb/run_tests
branch
from
6e8893c to
beda9ea
Compare
|
This regressed PkgEval times from 10h to 18h, so I'll likely revert this. Example run: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/3124e4e_vs_309021d/report.html |
maleadt
force-pushed
the
tb/run_tests
branch
2 times, most recently
from
8f14577 to
be75e2c
Compare
Use that as the fallback for blacklisted packages.
maleadt
force-pushed
the
tb/run_tests
branch
from
be75e2c to
732231e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use that as the fallback for blacklisted packages.
Fixes #271
Will only deploy next week.