Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Add a valid-name rule #131

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 20, 2024 · 1 comment · Fixed by #134
Closed
3 tasks done

🚀 Feature: Add a valid-name rule #131

JoshuaKGoldberg opened this issue Jan 20, 2024 · 1 comment · Fixed by #134
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
Full Recommended ...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Splitting out of #52: on second thought, https://npmpackagejsonlint.org/docs/rules/format/name-format is more than a "format this the way I prefer" rule. It enforces that the package name is valid per the npm spec. Good!

Let's add a standalone rule for this.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Jan 20, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 20, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 20, 2024
Open
This was referenced Jan 20, 2024
Open
Merged
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🚀 Feature: Add a valid-name 🚀 Feature: Add a valid-name rule Jan 20, 2024
JoshuaKGoldberg added a commit that referenced this issue Jan 20, 2024
@JoshuaKGoldberg
feat: added valid-name rule (#134)
ecf9266 
## PR Checklist

-   [x] Addresses an existing open issue: fixes #131
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds the rule using the same `validate-npm-package-name` dependency as
`npm-package-json-lint`.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v0.9.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
Full Recommended Config
Development

Successfully merging a pull request may close this issue.

feat: added valid-name rule JoshuaKGoldberg/eslint-plugin-package-json
1 participant
@JoshuaKGoldberg