New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible error when using mask for attention. #153

Open

TropComplique opened this issue Jun 5, 2024 · 0 comments

TropComplique commented Jun 5, 2024

Hi!
I believe that we must use a mask in window self attention only when we shift windows.
But here

SwinIR/models/network_swinir.py

Line 262 in 6545850

    
           attn_windows = self.attn(x_windows, mask=self.calculate_mask(x_size).to(x.device))

we use the mask all the time, for shifted and non shifted windows.

This might introduce errors at the bottom edge or at the right edge of an image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment