Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems SwinIR doesn't use patch merging. #136

Open
shallweiwei opened this issue Feb 23, 2023 · 2 comments
Open

It seems SwinIR doesn't use patch merging. #136

shallweiwei opened this issue Feb 23, 2023 · 2 comments

Comments

@shallweiwei
Copy link

Excellent work!
It seems that there is not patch merging.So it means different windows can't exchange information.I understand you don't want to downsample,but maybe the windows should connect with each other.

@BVlad917
Copy link

The windows can exchange information because the swin transformer blocks used are alternating between not shifted/shifted. When the shifted version is used (odd indexes) neighboring windows will be able to exchange information.

@zlbbme
Copy link

zlbbme commented Jun 2, 2023

Excellent work! It seems that there is not patch merging.So it means different windows can't exchange information.I understand you don't want to downsample,but maybe the windows should connect with each other.

I have the same confusion. How do you understand this question finally .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants