Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for camera distance #67

Open
nadewad opened this issue Dec 2, 2020 · 3 comments
Open

Add support for camera distance #67

nadewad opened this issue Dec 2, 2020 · 3 comments

Comments

@nadewad
Copy link

nadewad commented Dec 2, 2020

Considering that Skija is used to power compose on the desktop, there should be some parallel support for existing graphics facilities that are part of the compose API surface. Jetpack compose supports "camera distance" parameters on layer that is useful for handling rotations around the x and y axis (for example, card flip animations). This requires leveraging Sk3DView APIs in skia which would need to be included in the Skija bindings.

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-master-dev:compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/SkijaLayer.kt;l=130?q=SkijaLayer

A link to the implementation of camera distance in the Android framework is shown in this link and can be leveraged within the Skija implementation.

@tonsky
Copy link
Collaborator

tonsky commented Dec 3, 2020

Thanks, I’ll put in on the queue

@MMarco94
Copy link

MMarco94 commented Sep 5, 2021

Any update?

@tonsky
Copy link
Collaborator

tonsky commented Sep 5, 2021

No, sorry. What you are asking seems to be deprecated? https://github.com/google/skia/blob/f65cd9be733039d871e23eea8566bc2827dcbd6f/RELEASE_NOTES.txt#L564-L565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants