Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Scrollbars.kt #395

Open
3 tasks
morozkin opened this issue Jun 6, 2024 · 1 comment · May be fixed by #457
Open
3 tasks

Review Scrollbars.kt #395

morozkin opened this issue Jun 6, 2024 · 1 comment · May be fixed by #457
Assignees
@hamen
Labels
api Changes related to the public API bug Something isn't working

Comments

@morozkin
Copy link

morozkin commented Jun 6, 2024 •
edited
Loading

  • Make sure the same approach for hoverDurationMillis is used among all scroll bars
  • remember should be used with key as values are based on style and must reflect changes in style
  • remember values instead of MutableState (val shape = remember { RoundedCornerShape(style.metrics.thumbCornerSize) } instead of val shape by remember { mutableStateOf(RoundedCornerShape(style.metrics.thumbCornerSize)) })

Discussed here
@rock3r rock3r self-assigned this Jun 6, 2024
@rock3r rock3r added bug Something isn't working api Changes related to the public API labels Jun 6, 2024
@rock3r rock3r assigned hamen and unassigned rock3r Jul 22, 2024
@rock3r
Copy link
Collaborator

rock3r commented Jul 22, 2024

Probably made obsolete by the work on #445

@rock3r rock3r linked a pull request Jul 23, 2024 that will close this issue
Add scrollbars #457
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamen hamen

Labels
api Changes related to the public API bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add scrollbars JetBrains/jewel
3 participants
@hamen @rock3r @morozkin