Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure theme name is used as key instead of isDark where appropriate #354

Open
rock3r opened this issue Apr 15, 2024 · 0 comments
Open

Ensure theme name is used as key instead of isDark where appropriate #354

rock3r opened this issue Apr 15, 2024 · 0 comments
Assignees
Labels
feature New feature or request

Comments

@rock3r
Copy link
Collaborator

rock3r commented Apr 15, 2024

In the bridge, it's technically wrong to use isDark as remember key because the user may be switching between two different themes that are both light, or dark. E.g., Dark -> Darcula.

So the next step after #353 is to review usages of isDark as remember key, and replace them with the theme name, to avoid missing recompositions in the bridge.

This is only really a problem for the bridge, since in standalone you only have light or dark.

@rock3r rock3r added the feature New feature or request label Apr 15, 2024
@rock3r rock3r self-assigned this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant