Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CommonMark parsing speed by recomputing only the modified fragments. #333

Closed
obask opened this issue Mar 27, 2024 · 1 comment
Closed

Improve CommonMark parsing speed by recomputing only the modified fragments. #333

obask opened this issue Mar 27, 2024 · 1 comment
Assignees
@obask
Labels
feature New feature or request markdown This issue impacts the Markdown rendering subsystem

Comments

@obask
Copy link
Collaborator

obask commented Mar 27, 2024

We can diff changed blocks by running commonmark with this parameter .includeSourceSpans(IncludeSourceSpans.BLOCKS) and then finding the first and the last unchanged fragment of a string. Then run commonmark on items in between and replace these blocks in the Document's children list.
@obask obask added the feature New feature or request label Mar 27, 2024
@obask obask linked a pull request Mar 29, 2024 that will close this issue
Diff lines when deciding what blocks to update #335
Closed
@rock3r
Copy link
Collaborator

rock3r commented Apr 3, 2024

@obask is there more work to do beyond what #337 brought in? Can we close this issue?

@rock3r rock3r added the markdown This issue impacts the Markdown rendering subsystem label Jul 17, 2024
@rock3r rock3r closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obask obask

Labels
feature New feature or request markdown This issue impacts the Markdown rendering subsystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Diff lines when deciding what blocks to update JetBrains/jewel
2 participants
@rock3r @obask