Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes are not registered if Sanctum route registration is disabled #71

Open
newock opened this issue Aug 5, 2022 · 1 comment
Open
Labels
enhancement New feature or request good first issue Good for newcomers needs more info There was not enough information provided to troubleshoot this further

Comments

@newock
Copy link

newock commented Aug 5, 2022

Now (in ToolServiceProvider.php):

if (
    $this->app->routesAreCached() ||
    false === config("sanctum.routes")
) {
    return;
}

Should be:

if ($this->app->routesAreCached()) {
    return;
}

I'd like to be able to have the plugin routes without including Sanctum ones.

@JeffBeltran
Copy link
Owner

Thanks for the feedback @newock, im not familiar with this, looking over the history im wondering if this was part of the tool generation feature. I'll take a look when i get time but i wouldn't expect that to be anytime soon.

Happy to accept a PR if you can give me a bit more info why that was there in the first place vs why it is no longer there. I prefer to keep things the "nova way" as much as possible to make things easier to maintain.

@JeffBeltran JeffBeltran added enhancement New feature or request good first issue Good for newcomers needs more info There was not enough information provided to troubleshoot this further labels Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers needs more info There was not enough information provided to troubleshoot this further
Projects
None yet
Development

No branches or pull requests

2 participants