Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyStageLinQ.py to make it work with EngineOs 3.3.0 #34

Open
ssabug opened this issue Mar 3, 2024 · 4 comments
Open

Update PyStageLinQ.py to make it work with EngineOs 3.3.0 #34

ssabug opened this issue Mar 3, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ssabug
Copy link

ssabug commented Mar 3, 2024

Hi,

First thank you for providing this library, its very handy, and i was expecting this kind of tool for some time....(I use it on my "piratengine" repo, if you're interested)

I had to modify class PyStageLinQ and set ANNOUNCE_IP = "224.0.0.251" to have data flowing for my EngineOs hardware (firmware 3.3.0).

Is there another way if i was supposed to, or, if not, would it be possible to have this option in the constructor in the future?

Thanks in advance.

@Jaxc
Copy link
Owner

Jaxc commented Mar 28, 2024

Hello, sorry for the late answer

I don't think this is related to Engine Os 3.3.0 as it works fine for me, but I think this is a good feature. I'll try to fix add it!

@Jaxc Jaxc added the enhancement New feature or request label Mar 28, 2024
@Jaxc Jaxc self-assigned this Mar 28, 2024
@Jaxc
Copy link
Owner

Jaxc commented Aug 12, 2024

Hello again

I have punshed an update to PyStagLinQ that changes some basic things. I tested it with your repo and it seems to be working!

By default PyStageLinQ will now check all network interfaces on the host and send and receive discovery frames on all of them. It is possible to limit one IP by using e.g. PyStageLinQ(... , ip=192.168.1.13, ...). An idea for PirateEngine could be to add a menu to chose (all interfaces/each specific one) :)

@ssabug
Copy link
Author

ssabug commented Aug 12, 2024

Hi @Jaxc ,

Thank you for this :), ill have a look at it soon.

@ssabug
Copy link
Author

ssabug commented Aug 14, 2024

Hello,

I tested the new version 0.2.1 of your code with my piratengine app (see your pull request comments for details), and i have no device discovered anymore.

I tried the following cases for thePyStageLinQ constructor:

  • passing no ip
  • passing the local ip of the computer running the software
  • passing the former ANNOUNCE_IP value i had to put in the previous version (224.0.0.251)
  • tried even modifying the PyStageLinQ.py discovery_socket.sendto( discovery_frame, ("255.255.255.255", self.StageLinQ_discovery_port),) to previous value discovery_socket.sendto(discovery_frame, (ip, 51337))

All lead to no device discovery.

As i added multiples small changes in my code, i downgraded PyStageLinQ to 0.1.2 ( +changed to ANNOUNCE_IP="224.0.0.251" ) and tried again ; it worked.

As there's no version between 0.1.2 and 0.2.1, im running out of ideas on how to fix this.

Thank you in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants