Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockbench Transforms Bone Names #2594

Open
Ciosciaa opened this issue Dec 20, 2024 · 1 comment
Open

Blockbench Transforms Bone Names #2594

Ciosciaa opened this issue Dec 20, 2024 · 1 comment
Labels
improvement something that works as intended but could be improved to work better

Comments

@Ciosciaa
Copy link

Ciosciaa commented Dec 20, 2024

What are you trying to do, and what do you expect to happen?

In Minecraft, all non-empty strings are valid bone names. I expect Blockbench to support this behavior.

What happens instead?

Bone names are transformed, disrupting block, animation, render controller, and culling definitions. The simplest (and most harmful) example involves .s. Periods are stripped from bone names, leaving links to such names in other definitions invalid.

A more radical example could be: banister.geo.json. When this geometry definition is opened and saved in Blockbench, the bone name `!@#$%~^&*()_+-={}[]|;:'",<.>/?∆🦋 is transformed to __. However, `!@#$%~^&*()_+-={}[]|;:'",<.>/?∆🦋 is a valid bone name in the engine.

Model format in which the issue occurs

Bedrock Block, Bedrock Entity

Blockbench variant

Program

Blockbench version

4.12.0 Beta 1

Operating System

macOS Sequoia 15.2

Installed Blockbench plugins

N/A

@JannisX11
Copy link
Owner

Any reason why you need to have support for all special characters in bone names? They are fine when just used in a model, but will break the asset as soon as you need to reference those bones in animations, render controllers etc. Blockbench sanitizes bone names to prevent issues like that.

I can add supports for periods though. It looks like those are supported everywhere for bone names.

@JannisX11 JannisX11 added the improvement something that works as intended but could be improved to work better label Dec 22, 2024
@JannisX11 JannisX11 moved this to Unreleased in Blockbench Planning Dec 22, 2024
JannisX11 added a commit that referenced this issue Dec 22, 2024
Add format property node_name_regex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement something that works as intended but could be improved to work better
Projects
Status: Unreleased
Development

No branches or pull requests

2 participants