Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send files and folders via command line argument #75

Closed
2 tasks done
Dr-Hex opened this issue Mar 20, 2023 · 9 comments
Closed
2 tasks done

Send files and folders via command line argument #75

Dr-Hex opened this issue Mar 20, 2023 · 9 comments
Labels
enhancement New feature or request
Milestone

Comments

@Dr-Hex
Copy link

Dr-Hex commented Mar 20, 2023

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

Please, add the ability to accept command line argument to have faster and convenient way to download/upload files and folders.

Describe the solution you'd like to see.

Examples:

rymdport.exe "C:\...\file.txt"
should recognize 1st argument as a file and automatically start uploading it.

rymdport.exe "C:\...\folder"
should recognize 1st argument as a folder and automatically start uploading it.

rymdport.exe 4-backwater-spin
should recognize 1st argument as alias and automatically download the appropriate file or folder.

@Dr-Hex Dr-Hex added the enhancement New feature or request label Mar 20, 2023
@Jacalz
Copy link
Owner

Jacalz commented Mar 20, 2023

Am I correct in understanding that you want this to also open the application at the same time?
I.e. that passing a file or code should open the application and start the transfer?

If not, I'd recommend that you install https://github.com/psanford/wormhole-william instead.

@Jacalz Jacalz added this to the Undecided milestone Mar 20, 2023
@Jacalz Jacalz added good first issue Good for newcomers and removed good first issue Good for newcomers labels Mar 20, 2023
@Dr-Hex
Copy link
Author

Dr-Hex commented Mar 21, 2023

Am I correct in understanding that you want this to also open the application at the same time? I.e. that passing a file or code should open the application and start the transfer?

Sure.

If not, I'd recommend that you install https://github.com/psanford/wormhole-william instead.

Thanks for alternate suggestion.

@Jacalz
Copy link
Owner

Jacalz commented Mar 21, 2023

Cool. Thanks for confirming. I think this would require quite a lot of changes at the moment.

Thinking about this, I'd rather just implement support for passing files/folders as part of opening a file from a file manager in Rymdport (like a "Send with Rymdport" context menu or similar). Most other cases should be covered by using a cli as the one mentioned above.

@Dr-Hex
Copy link
Author

Dr-Hex commented Mar 21, 2023

Yeah, it would be cool to pass direct path, because the current menu is, well, quite too non-convernient (large icons, little window size, require too much scrolling, clicking etc to make a simple action - select the desired file).

@Dr-Hex
Copy link
Author

Dr-Hex commented Mar 21, 2023

Also, not sure why, however, it's the first time when I see the OS Windows "Send to" context menu doesn't display the item, when I place the shortcut of your program onto the folder

%APPDATA%\Microsoft\Windows\SendTo

@Jacalz
Copy link
Owner

Jacalz commented Mar 21, 2023

Yeah, it would be cool to pass direct path, because the current menu is, well, quite too non-convernient (large icons, little window size, require too much scrolling, clicking etc to make a simple action - select the desired file).

Yeah, I know that is unfortunately. It is a bit blocked on the upstream GUI toolkit not providing nicer file pickers. I might be able to use a library like https://github.com/ncruces/zenity for native dialogs but I haven't gotten around to it yet and I don't know how well they work with UI interaction (wants to block the UI while they are open etc).

Also, not sure why, however, it's the first time when I see the OS Windows "Send to" context menu doesn't display the item, when I place the shortcut of your program onto the folder

I didn't know that it existed. Interesting. I'm not a Windows user so I can't tell you why really but I expect it might be because the application doesn't expose any context menu actions in the manifest

@Jacalz
Copy link
Owner

Jacalz commented Jun 27, 2023

I think I have decided on the path forward here. The plan is to implement sending by right-clicking in the file manger (see #91) and that will require being able to pass files and folders as input through the command line. That part will have to be implemented for that to work and I think it might be generally useful for some people as well.

However, I don’t see quite the same need for implementing the same support for receiving (it can’t happen from the file manager and seems less useful to me). If someone wants to receive items using the terminal, I believe the best option is using a terminal client for Magic Wormhole instead (as mentioned above).

@Jacalz Jacalz modified the milestones: Undecided, v3.5.0 Jun 27, 2023
@Jacalz Jacalz changed the title Download and upload files via command line argument Send files and folders via command line argument Jun 27, 2023
Jacalz added a commit that referenced this issue Jun 28, 2023
Intended for getting #91 working, at least on Linux and BSD, in the future.

Fixes #75
@Jacalz
Copy link
Owner

Jacalz commented Jun 28, 2023

This has now been resolved with 40aacdd. Thanks for opening this issue.

@Jacalz Jacalz closed this as completed Jun 28, 2023
@Jacalz
Copy link
Owner

Jacalz commented Jun 28, 2023

The receiver side of this will probably be more-or less solved when #92 gets implemented.

Jacalz added a commit that referenced this issue Sep 2, 2023
Intended for getting #91 working, at least on Linux and BSD, in the future.

Fixes #75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants