Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayland Support? #122

Open
2 tasks done
secretmango opened this issue Oct 18, 2023 · 6 comments
Open
2 tasks done

Wayland Support? #122

secretmango opened this issue Oct 18, 2023 · 6 comments
Labels
enhancement New feature or request os-linux Issues specific to running on Linux
Milestone

Comments

@secretmango
Copy link

secretmango commented Oct 18, 2023

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

Currently the app uses XWayland which is not a huge deal but still native Wayland would be better

Describe the solution you'd like to see.

Wayland support natively ;D

Alternatives

Warp, also on Flathub

@secretmango secretmango added the enhancement New feature or request label Oct 18, 2023
@Jacalz
Copy link
Owner

Jacalz commented Oct 18, 2023

There is only half-working support for Wayland in the widget toolkit that I'm using (Fyne). You can compile Rymdport with -tags Wayland (I'll make sure to update the documentation) but it doesn't work very well.

As a primary Gnome Wayland user, I agree entirely that Wayland support would be very nice. Unfortunately the stable glfw release only supports to be compiled with either X11 or Wayland support but not both. Once Fyne has better Wayland support, I will update the Flatpak package to have both binaries and start the appropriate one depending on the windowing system in use 😅

@Jacalz Jacalz added os-linux Issues specific to running on Linux blocked Blocked by issues elsewhere. labels Oct 18, 2023
@secretmango
Copy link
Author

secretmango commented Oct 18, 2023

thanks for your reply!

To be honest, I could also imagine that you have something better to do than maintaining such a pain in that case ;D What about just contributing to Warp? It uses libadwaita and all, should work perfectly on Gnome.

There are some apps like Firefox starting to build Wayland-only builds. There really is no big problem with that, if X11 will be dropped anyways.

So for the time being, if only seperate builds are supported, why not clone the repo and call it "rymdport-x11" ? The problem here would be to have the app semi-broken at the beginning, but this could be mentioned in the Metadata. The advantage would be that the futureproof version would keep its original name.

@Jacalz
Copy link
Owner

Jacalz commented Oct 18, 2023

To be honest, I could also imagine that you have something better to do than maintaining such a pain in that case

It shouldn't be too bad I think. But yeah, sooner or later I'd probably switch to Wayland only (likely once Gnome and maybe KDE removes X11 support entirely) but the support in Fyne needs to improve before that can happen. Just having a small shell script that launches the corresponding binary will be suited in the meantime.

What about just contributing to Warp? It uses libadwaita and all, should work perfectly on Gnome.

I hope you are kidding. There is nothing about this project that is about supporting Gnome specifically. I've poured hundreds if not thousands of hours into this project and I want it to run on as many platforms as possible. Neither do I know the Rust language well enough.

So for the time being, if only seperate builds are supported, why not clone the repo and call it "rymdport-x11" ?

I don't need to change any code so there is no point in closing the repo. But yeah, I can definitely add separate Wayland-only builds to the releases if I want to but there is no point in doing so just yet due to the poor Wayland support in Fyne.

@secretmango
Copy link
Author

secretmango commented Oct 18, 2023

Oh okay thanks for the heads up! Tbh Warp doesnt look that well on KDE ;D

@Jacalz Jacalz added this to the v3.7.0 milestone Jan 17, 2024
@Jacalz
Copy link
Owner

Jacalz commented Jan 17, 2024

I have started work on initial Wayland improvements upstream in fyne-io/fyne#4481. Planning on landing Fyne update in v3.7.0 release and then have a script to launch the Wayland/X11 binaries depending on $XDG_SESSION_TYPE.

@Jacalz Jacalz removed the blocked Blocked by issues elsewhere. label Jan 17, 2024
@secretmango
Copy link
Author

very cool! Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request os-linux Issues specific to running on Linux
Projects
None yet
Development

No branches or pull requests

2 participants