Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce zero-warning policy #280

Open
2 of 3 tasks
Jacajack opened this issue Nov 6, 2023 · 1 comment
Open
2 of 3 tasks

Enforce zero-warning policy #280

Jacajack opened this issue Nov 6, 2023 · 1 comment
Assignees
@Jacajack @WojciechPtas
Labels
enhancement New feature or request nice to have Only if we have time

Comments

@Jacajack
Copy link
Owner

Jacajack commented Nov 6, 2023 •
edited
Loading

Let's clean up all warnings in our code and run cargo clippy. After that we should embrace zero-warning policy on main branch enforced by the CI.
@Jacajack Jacajack added the enhancement New feature or request label Nov 6, 2023
@Jacajack Jacajack changed the title Warning-free code Enforce zero-warning policy Nov 6, 2023
@Jacajack Jacajack added the nice to have Only if we have time label Nov 27, 2023
@Jacajack
Copy link
Owner Author

Jacajack commented Dec 2, 2023

@WojciechPtas you can now clean warnings in hdl and add RUSTFLAGS="--deny warnings" env var in the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jacajack Jacajack

@WojciechPtas WojciechPtas

Labels
enhancement New feature or request nice to have Only if we have time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jacajack @WojciechPtas