Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional nickname argument to /join command #647

Open
Tha14 opened this issue Jul 12, 2023 · 1 comment
Open

feat: add optional nickname argument to /join command #647

Tha14 opened this issue Jul 12, 2023 · 1 comment

Comments

@Tha14
Copy link
Contributor

Tha14 commented Jul 12, 2023

When initially joining a group chat there should be an option to define the nickname with which we will be joining said group chat. The only thing that I am not sure about is how this optional command would work out as we already have the password argument as an optional parameter.
Current example:
/join {GROUP_CHATID} [PASSWORD]
My current idea:
/join {GROUP_CHATID} [NICKNAME] [PASSWORD]

@JFreegman
Copy link
Owner

JFreegman commented Jul 13, 2023

Both a nick and a password can contain spaces. In order to allow for both arguments you'd need to add quotes to the arguments and parse it appropriately. It's a pain in the ass and is ugly. An alternative solution could be to put an optional name argument before the ID. You would be able to exclude quotations because only one of the arguments can have 64 contiguous characters. Anything before that arg is a nick, and anything after is a password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants