Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TL module updates for aircraft-level/user-defined-level upward/downward radiance #182

Open
chengdang opened this issue Sep 25, 2024 · 5 comments
Assignees

Comments

@chengdang
Copy link
Contributor

chengdang commented Sep 25, 2024

TL module updates for the following new features have been added to branch: https://github.com/JCSDA/CRTMv3/tree/feature/cd_AirCraft_TL

  • aircraft-level upward radiance
  • user-defined-level downward radiance

Besides these updates, I also included a lot of comments for the ADA module in general for future reference.

@chengdang chengdang self-assigned this Sep 25, 2024
@chengdang
Copy link
Contributor Author

These updates are built upon PR #179, and should be tested after merging this PR first.

@chengdang
Copy link
Contributor Author

Note 1:
The computed radiance TL is assigned within module CRTM_ADA_TL,

! Assign radiance TL

while for the forward calculation, the radiance is assigned within Assign_Common_Output
! The output radiance at TOA or at Aircraft height

This is because the TL profiles are not stored in any data structure for TL modules to use outside of CRTM_ADA_TL

@chengdang
Copy link
Contributor Author

chengdang commented Sep 25, 2024

Note 2:

The output of CRTM_ADA_TL is changed into a new variable s_rad_TL , which can be either upward/downward radiance TL

s_rad_TL) ! Output TL radiance

The original output variable s_rad_up_TL is kept as a local variable in CRTM_ADA_TL

The computed TL results are identical compare to the dev branch. (TOA only)

@chengdang
Copy link
Contributor Author

Note 3:

Several ctests have been added/updated to test the model updates:

list( APPEND TLAD_tests

list( APPEND Aircraft_Sensor_Ids

list( APPEND Downwelling_Radiance_Sensor_Ids

For now the tests run as expected.

@chengdang
Copy link
Contributor Author

Note 4:

It is unclear if the TL module updates are scientifically correct, more scientific tests/code review are needed from the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant