Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated spec to fix a conformance failure #4756

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Nov 15, 2024

Description

This PR bumps the spec to a version that calculates refunds properly. I also modified the extraInfo method to give access to the final state when creating the debug message.

closes #4754

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw marked this pull request as ready for review November 15, 2024 14:25
@Soupstraw Soupstraw requested a review from a team as a code owner November 15, 2024 14:25
@Soupstraw Soupstraw force-pushed the jj/conformance-bump branch 4 times, most recently from bfee36e to b677e0b Compare November 15, 2024 14:41
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some questions and observations.

@Soupstraw Soupstraw force-pushed the jj/conformance-bump branch 3 times, most recently from 020b66b to d3daadb Compare November 18, 2024 11:23
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to run fourmolu. Other than that it is good to go.

Co-authored-by: teodanciu <[email protected]>
@Soupstraw Soupstraw enabled auto-merge (rebase) November 19, 2024 10:22
@Soupstraw Soupstraw merged commit 9070dbd into master Nov 19, 2024
158 of 159 checks passed
@Soupstraw Soupstraw deleted the jj/conformance-bump branch November 19, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conformance test failure on CI
3 participants