CDDL:babbage: Switch to using Huddle/Cuddle #4785
Open
+990
−451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
force-pushed
the
aniketd/huddle-babbage
branch
3 times, most recently
from
a1c9d54 to
b5087e1
Compare
aniketd
force-pushed
the
aniketd/huddle-babbage
branch
from
b5087e1 to
59c79a6
Compare
teodanciu
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Looks good to me, went through the cddl differences and found a few fields which were incorrectly indicated as NEW in the comment, and a difference which is more significant in the way the protocol_version is defined, and the latter I believe we need to fix before merging.
Nice work!
10 tasks
- Remove - crypto.cddl - extras.cddl - Add - Test.Cardano.Ledger.Babbage.CDDL - cardano-ledger-babbage:exe:huddle-cddle - huddleRoundTrip(Ann)CborSpec for all definitions already being tested - Autogenerate babbage.cddl using Huddle/Cuddle - Update - hie.yaml with babbage paths module and huddle-cddl - gen-cddl.sh to include babbage - Update `operational_cert` definition to preserve the keys
aniketd
force-pushed
the
aniketd/huddle-babbage
branch
from
59c79a6 to
4199281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4781
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)