Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set maxTxSize to a sensible value in conformance tests #4702

Open
teodanciu opened this issue Oct 17, 2024 · 0 comments
Open

Set maxTxSize to a sensible value in conformance tests #4702

teodanciu opened this issue Oct 17, 2024 · 0 comments

Comments

@teodanciu
Copy link
Contributor

UTXO rule in ledger checks that the size of a transaction doesn't exceed maxTxSize pparam. However, this check does not seem to be implemented in the Agda spec, so until this happens, we have to generate transactions that won't cause this predicate failure.
The way it's been done at the moment in the UTXO conformance test is to set the pparam to be the size of the generated transaction, which is a workaround to prevent the maxSize being exceeded and hence the test from failing.

Once the check is implemented in the spec, we should set this value in a more intelligent way: perhaps in different test cases to:

  • test that the check is indeed happening as it should (when set to something small
  • for it to be more realistic, otherwise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants