Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance DELEG: Extract Deleg ExecSpecRule and SpecTranslate instances #4469

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Jul 4, 2024

Description

In this PR, I:

  • extracted the DELEG-related instances from ExecSpecRule and SpecTranslate Base modules to the respective Deleg module.
  • implemented the missing translation for toSpecRep ConwayRegCert
  • re-enabled ConwayRegCert in both CERT and Deleg ExecSpecRule modules

Resolves #4465

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu force-pushed the td/extract-deleg-exec-and-translate branch 7 times, most recently from e174823 to 66dde1b Compare July 10, 2024 11:59
Copy link
Contributor

@Lucsanszky Lucsanszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@lehins lehins force-pushed the td/extract-deleg-exec-and-translate branch from 66dde1b to 037bc84 Compare July 10, 2024 19:34
@teodanciu teodanciu enabled auto-merge July 10, 2024 19:46
@teodanciu teodanciu force-pushed the td/extract-deleg-exec-and-translate branch from 037bc84 to 4ffa78f Compare July 11, 2024 08:36
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉 🙌

@teodanciu teodanciu force-pushed the td/extract-deleg-exec-and-translate branch from 4ffa78f to 40b6334 Compare July 11, 2024 12:02
@teodanciu teodanciu merged commit 0274cf6 into master Jul 11, 2024
125 checks passed
@teodanciu teodanciu deleted the td/extract-deleg-exec-and-translate branch July 11, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conway conformance: DELEG - Translate
3 participants