Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance test plumbing: CERTS #4474

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conformance test plumbing: CERTS #4474

merged 1 commit into from
Jul 16, 2024

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Jul 5, 2024 •
edited
Loading

Description

Resolves #4463

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Lucsanszky Lucsanszky force-pushed the ldan/conformance-plumbing-certs branch 2 times, most recently from 6819e50 to 9c94edd Compare July 16, 2024 00:18
@Lucsanszky Lucsanszky marked this pull request as ready for review July 16, 2024 00:20
TimSheard
TimSheard approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good solid attempt getting the framework set up.
We will need to pay some attention to the 2 properties mentioned in the review in the follow-on PR

.../cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Conway/Certs.hs Show resolved Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/Certs.hs Show resolved Hide resolved
@Lucsanszky Lucsanszky force-pushed the ldan/conformance-plumbing-certs branch from 9c94edd to 336b9a6 Compare July 16, 2024 12:59
teodanciu
teodanciu approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Lucsanszky Lucsanszky merged commit 93e5f8c into master Jul 16, 2024
122 of 126 checks passed
@Lucsanszky Lucsanszky deleted the ldan/conformance-plumbing-certs branch July 16, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teodanciu teodanciu teodanciu approved these changes

@TimSheard TimSheard TimSheard approved these changes

@lehins lehins Awaiting requested review from lehins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conformance test plumbing: CERTS
3 participants
@Lucsanszky @teodanciu @TimSheard