fatal error message when loading from a non-git directory

[rmkaplan]

I routinely run the loadup script in my working directory, which is not a git clone.

I noticed that at almost every step it prints out
fatal: not a git repository (or any of the parent directories): .git

It's true that it isn't a repository, but did something really go wrong? Or it's just an error message that should be suppressed or phrased in a different way.

Is there something wrong with building in a non-repository?

This is on Mac 14.6.1 Sonoma

[nbriggs]

There's nothing actually wrong -- it's just that the setup script tries to figure out the git commit id of what you're building from and in the non-repository case git itself reports "fatal: not a git repository (or any of the parent directories)". It does that to standard error, so we could add a 2>/dev/null to the git commands in there, which would just make it silent. It's too bad there's no --silent or --quiet option.

[rmkaplan]

Thanks

…

On Dec 21, 2024, at 11:55 AM, Nick Briggs ***@***.***> wrote: There's nothing actually wrong -- it's just that the setup script tries to figure out the git commit id of what you're building from and in the non-repository case git itself reports "fatal: not a git repository (or any of the parent directories)". It does that to standard error, so we could add a 2>/dev/null to the git commands in there, which would just make it silent. It's too bad there's no --silent or --quiet option. — Reply to this email directly, view it on GitHub <#1927 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJLK7W2RBAL6RFQCQ532GXBU3AVCNFSM6AAAAABT6FTRDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJYGIZDEMJSGA>. You are receiving this because you authored the thread.

[nbriggs]

I'd suggest this patch to medley/scripts/loadup-setup.sh

diff --git a/scripts/loadup-setup.sh b/scripts/loadup-setup.sh
index be7305b2..47825408 100644
--- a/scripts/loadup-setup.sh
+++ b/scripts/loadup-setup.sh
@@ -50,15 +50,9 @@ then
   fi
 fi
 
-HAS_GIT= [ -f $(which git) ] && [ -x $(which git) ]
-export HAS_GIT
-
 git_commit_ID () {
-  if ${HAS_GIT};
-  then
-    # This does NOT indicate if there are any modified files!
-    COMMIT_ID=$(git -C "$1" rev-parse --short HEAD)
-  fi
+# This does NOT indicate if there are any modified files!
+COMMIT_ID=$(git -C "$1" rev-parse --short HEAD 2>/dev/null)
 }
 
 git_commit_ID "${LOADUP_SOURCEDIR}"

there is no other use of HAS_GIT in any of the scripts, the existing code doesn't appear to work cleanly if git is not installed, and if git exists but the script is run in a non-repo, it prints git's "fatal: ..." error message.

[nbriggs]

For reference - this is the script fragment I use for the Maiko git revision to determine if git is installed and the command is being executed within a git repository:

if command -v "git" >/dev/null 2>&1; then
    MAIKO_REV="$(git status --porcelain)"
    if [ $? == 0 ]; then
        if [ ! -z "$(git status --porcelain)" ]; then
            MAIKO_REV="$(git rev-parse --short HEAD)-dirty"
        else
            MAIKO_REV="$(git rev-parse --short HEAD)"
        fi
    else
        MAIKO_REV="none"
    fi
else
    MAIKO_REV = "none"
fi