Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework on AE/RS Bridge #600

Closed
wants to merge 1 commit into from
Closed

Rework on AE/RS Bridge #600

wants to merge 1 commit into from

Conversation

zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Apr 26, 2024 •
edited
Loading

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. This is not mandatory
  • All changes have fully been tested

  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Bug fix & reforge codes

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    Yes, absolutely. However, scripts do not have to change.

  • Other information:

@zyxkad zyxkad linked an issue Apr 26, 2024 that may be closed by this pull request
RS Bridge not showing isCraftable = true in getItem or getPattern #577
Open
@zyxkad zyxkad changed the title rework on RS Bridge Rework on AE/RS Bridge Apr 26, 2024
@SirEndii SirEndii added the needs review Needs review from an Contributor label Apr 27, 2024
@zyxkad
Copy link
Collaborator Author

zyxkad commented May 1, 2024

I just saw you did that on 1.20.1, so prob this is not needed anymore

@zyxkad zyxkad closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review Needs review from an Contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RS Bridge not showing isCraftable = true in getItem or getPattern
2 participants
@zyxkad @SirEndii