Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC2 integration #259

Closed
SirEndii opened this issue Jan 30, 2022 · 12 comments
Closed

OC2 integration #259

SirEndii opened this issue Jan 30, 2022 · 12 comments
Assignees
Labels
Milestone

Comments

@SirEndii
Copy link
Member

SirEndii commented Jan 30, 2022

Describe your idea

Before anyone asks, I'll just create a feature request directly.
Adding OC2 integration to AP.

Describe alternatives you've considered if you've any

No response

Additional context

https://www.curseforge.com/minecraft/mc-mods/oc2?t=kCSXxSMmvEldLgPycfMRkg&s=09

Linked branch

https://github.com/Seniorendi/AdvancedPeripherals/tree/oc2

@SirEndii SirEndii added this to the 0.8r milestone Jan 30, 2022
@SirEndii SirEndii pinned this issue Jan 30, 2022
@SirEndii SirEndii added the enhancement New feature or request label Jan 30, 2022
@SirEndii SirEndii self-assigned this Feb 10, 2022
@kristibektashi
Copy link

Will there be OC1 integration when they update? (if they update)

@SirEndii
Copy link
Member Author

Will there be OC1 integration when they update? (if they update)

OC is already updated to modern versions → https://www.curseforge.com/minecraft/mc-mods/oc2
But since oc2 isn't that popular and that there's only an alpha 1.18 version, I'll not add OC2 support in the near future

@kristibektashi
Copy link

Will there be OC1 integration when they update? (if they update)

OC is already updated to modern versions → https://www.curseforge.com/minecraft/mc-mods/oc2 But since oc2 isn't that popular and that there's only an alpha 1.18 version, I'll not add OC2 support in the near future

I'm not talking about OC2. I meant the original OpenComputers. There have been plans to port it to 1.16.5: MightyPirates/OpenComputers#3572

@SirEndii
Copy link
Member Author

OC1 has the same author(s) as OC2
https://www.curseforge.com/minecraft/mc-mods/oc2
https://www.curseforge.com/minecraft/mc-mods/opencomputers

I have no clue what this PR exactly is, but there is already a wonderful 1.18 port
We also do not support 1.16 anymore

@walksanatora
Copy link

but there is already a wonderful 1.18 port

can you link this? I haven't seen it

@SirEndii
Copy link
Member Author

but there is already a wonderful 1.18 port

can you link this? I haven't seen it

https://www.curseforge.com/minecraft/mc-mods/oc2/files

@walksanatora
Copy link

but there is already a wonderful 1.18 port

can you link this? I haven't seen it

https://www.curseforge.com/minecraft/mc-mods/oc2/files

oc2 != oc
oc2 is a RISCV VM, oc is lua

@SirEndii
Copy link
Member Author

can't you run lua scripts on oc2 too?

@SirEndii
Copy link
Member Author

I'll close this since there isn't currently any active oc port

@kristibektashi
Copy link

but there is already a wonderful 1.18 port

can you link this? I haven't seen it

https://www.curseforge.com/minecraft/mc-mods/oc2/files

oc2 != oc
oc2 is a RISCV VM, oc is lua

This is exactly my point. OC2 != OC1. OC1 has already been (mostly) ported to 1.16, and most likely will eventually be ported to newer MC versions. I believe it would be nice to have both OC1 and OC2 support when both of these are (eventually) ported to 1.19.

@kristibektashi
Copy link

can't you run lua scripts on oc2 too?

OC2 is a full Linux VM, so in certain cases it can be a security risk, especially on public servers. In those cases it is more likely for someone to use OC1 than OC2 (when it is eventually ported)

@kristibektashi
Copy link

I personally believe both should be supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants