Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest Making infinite-proxy Implementation Compliant with EIP-2535 Diamonds #6

Open
mudgen opened this issue Jun 11, 2022 · 0 comments

Comments

@mudgen
Copy link

mudgen commented Jun 11, 2022

It seems possible that the infinite-proxy implementation here could be made compliant with EIP-2535 Diamonds, Multi-Facet Proxy standard. Doing so would add the infinite-proxy implementation to the growing developer base of diamond developers, and make infinite-proxy implementations work with diamond tooling.

Specifically inifinite-proxy would need to implement the Implementation Points, which means adding an implementation contract/facet for the Loupe functions, and emitting the functions that are added/replaced/removed with the DiamondCut event. Note that the diamondCut function for upgrades defined in the standard is optional and other, different methods of upgrade, such as given in infinite-proxy are Okay, as long as the DiamondCut event is emitted, which enables interoperability for tools that show upgrade information for any diamond.

Much information about diamonds has been written and a starting point is here: https://github.com/mudgen/awesome-diamonds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant