ITK Build failure in External Module

[dyollb]

I am adding a small feature to my external module and got a build error for ITK. Should I update the github action?

https://github.com/dyollb/ITKLabelPointSet/actions/runs/11892961356/job/33136911530

[dzenanz]

InsightSoftwareConsortium/ITK#4820 was fixed yesterday in the main repository.

[dyollb]

hmm. thanks @dzenanz. I would have assumed the action would take the tagged version 5.4.0, in order to make sure wheels built later are still based on a specific version and will be compatible...

• was the bug already in ITK==5.4.0, and if yes, why did my CI not fail previously? Are third-parties not pinned to a specific version?
• can I release the wheels even if the cxx windows build fails (all python stages succeed) by pushing a tag? I'm guessing the answer is yes, since there don't seem to be dependencies to the cxx stages.

PR: dyollb/ITKLabelPointSet#7

[dzenanz]

Maybe the MSVC version was updated in CI's Windows machine image? If the wheels build without errors, they should work, even if build-and-test fails due to compile error.

[dzenanz]

Yes, third party libraries are quite a fixed version, which is infrequently updated. libTIFF was not update in a decade, it seems. And yesterday's "refresh" was preparation for an update, not an update in itself.

[dyollb]

Seems the mac os version is deprecated. All non-arm mac os jobs were cancelled:
https://github.com/dyollb/ITKLabelPointSet/actions/runs/11895490090

[dzenanz]

Here is how to update: InsightSoftwareConsortium/ITKIOOMEZarrNGFF#75

I think I added it as a PR here too, but I can't find the PR now.

[dzenanz]

Ahh, that PR is here: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#95

[dyollb]

thanks, that is great.

Can I use the fixed version by changing the tag from

    uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/[email protected]

to

    uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-cxx.yml@some-hash

[dzenanz]

Yes. We should probably also update 5.4.0 branch. @thewtex, @jhlegarreta, and @N-Dekker, what do you think?

[thewtex]

Patch to address the libtiff symbol in remote module CI builds: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#97