COMP: itktiff: Suppress C99 inline only on MSVC from VS 2013 and below - For Release Branch #4958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the condition from commit 08bf6be (COMP: Conditionalize insane "#define inline" in libtiff, 2013-10-07, v4.5rc01~139^2). Newer MSVC versions need it to avoid duplicating `__ucrt_int_to_float`. Issue: InsightSoftwareConsortium#4820
github-actions
bot
added
type:Compiler
|
@dyollb yes, this fix should be backported. |
|
Related discussion: InsightSoftwareConsortium/ITKModuleTemplate#167. |
dzenanz
approved these changes
Nov 18, 2024
thewtex
approved these changes
Nov 21, 2024
thewtex
merged commit 49413c3
into
InsightSoftwareConsortium:release-5.4
16 of 17 checks passed
thewtex
added a commit
to thewtex/ITKRemoteModuleBuildTestPackageAction
that referenced
this pull request
Nov 21, 2024
Incorporates libtiff symbol conflicts addressed in InsightSoftwareConsortium/ITK#4958 which has started to cause issues on Windows builds.
|
Hi @thewtex, is this PR going to be merged into master? |
|
This PR/commit was not explicitly merged to |
In short, ITK master now has libtiff version 4.7.0. Please let us know if there are any issues. |
|
Thanks @dzenanz @blowekamp, I'll try this out |
|
Update: ITK now builds on Windows for me. Thanks for these fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the condition from commit 08bf6be (COMP: Conditionalize insane "#define inline" in libtiff, 2013-10-07, v4.5rc01~139^2). Newer MSVC versions need it to avoid duplicating
__ucrt_int_to_float.Issue: #4820
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.