-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SuperPower-uC Original Review #57
Comments
What is the purpose of R4/R5 having both JP1/JP2? It seems that JP1/JP2 satisfies the need for tying the CELLS0/1 signals to their appropriate nodes.
|
Consider removing R13. |
Consider changing R1 to be 470 Ohm. This will eliminate a unique part on the BOM, and is within the suggested range on the datasheet. |
R11 and R7 can probably be unified to a single value to eliminate a unique part.
|
Some answers to questions regarding RTC and regulators:
These resistor values are taken from the datasheet to select the desired voltage. They may be replaced like you said to get component use down.
These symbols were directly taken from SnapEDA. Yes, they should be reworked. They are ugly.
These sizes are written down there, just because the datasheet listed them there like that even with these exact values. That can be removed later, but I wanted to make sure that this isn't accidentally overseen and poorly chosen.
Like the annotation says, there should be an exposed pin. This will manually wake up the board if something external happens.
Should be removed as soon as the BOM is fixed. As explained above, these sizes may be important as they are listed in the datasheet. It's just a very visible reminder. |
So just to clear up a choice in words: The phrase "power oring" is not powering, nor power o-ring. It is "Power OR-ing". As in, it is selecting power from A OR B. |
Good catch. I don't know why I wrote oring... BTW, for the VIN on the MCU sheet, at one moment I was thinking about adding it to the main pins headers of the board. It's often done on other boards, but it can be removed if it's not pertinent. Personnally for the IO2, 13 and 15, I'd connect them to the pin headers too. They are still IO and it's easier for the troubleshooting to have them mapped too. |
I believe the note "Permanent Power Jumper" should be on the charging module block. This is the circuit R14/Q4A, correct?
|
Charger - 390k R13 should be after Q3 and not in between Q4 and Q3! |
what is that resistor for R3 when the battery has an internal protection?
|
SMBALTER LED Resistor has no value |
solder jumper part looks quite complicated do to its symbols, maybe we choose a "easier to read" symbol which creates less track-crossings |
move all images in this sheet to ReadTheDocs on a separate page to explain the settings a bit more detailed. Image do not fit in the svg or pdf format because they do not scale. |
SMBALERT might be usefull for the MCU as well, at least add a TP to it. We might wake the MCU when SMBALTER interrupts. (Default is no alert, so it is programmable) |
Battery protection sheet, charger sheet and the charger i/O sheet having an connector for the battery. On the Charger I/O it is marked wrong with V_CHARGE as an input. This can be removed but it uses the S2B-PH-SM4-TB(LF)(SN) connector as a label which is commonly used for batteries, we should keep it. I also would remove the connector from the charger sheet and only keep it on the battery protection sheet. We might then just add 2 pads as well for soldering a battery if wanted.
Rem. : It was previously talked on the chat ! |
The charger I/O sheet should only get solder pads + barrel jack and no connector or screw-terminal. (maybe screw-terminal but they are big and ugly and expensive)
|
okay - gotcha! I looked at it again and I see it now, thanks |
of course - if we it is just a formula we should leave it but as text. and curves and things go into ReadTheDocs. We can also have a whole section for calculations and formulars on RTD which we can link in the schematics (just hard to type because I think there are no links :) ) |
the JST PH connector is the one we should use for the battery. If you check Adafruit you can get lots of batteries there with that connector. The I/O sheet has this connector but it was /is a mistake by me. The idea was to have this for the battery. I might mix things up so I try to clean it: INPUT/OUTPUT: Battery Would this answer the confusion? |
now I get it - okay |
Answer |
commit: 7201a1d
Schematic review only.
Review sethkaz:
Fix:
You really should Fix:
Consider fixing:
Comments:
Review informatic0re:
Gerneral
Battery Protection
Charger
Charger I/O
"Power oring" Lable should be "Powering", I guessRTC
Regulator
MCU
Review ManWithNoName:
General
There is 7 (maybe 8) Power P-MOSFETs on the board :
Total Max : x8
I think that we should use the same Power P-MOSFETs for all the board.
PS : I have choosen a SOIC-8 Dual P-MOFET in the charger module.
Modules (Top Level)
Place the label 3v3_RTC on the right (this is an output)
Replace Vin label by 3v3_RTC to avoid confusion.
Cut the 3v3_MCU link between them.
Rename the 3v3_MCU label on the Charger IC block by 3v3_RTC and add a link between them (3v3_RTC).
Battery Protection
NTR
Charger
To leave more free space on the board, I think that we should remove JP2 and connect CELLS1 pin directly to INTVcc. (see table 5 on datasheet). In this case, we can also remove R5.
Charger I/O
RTC
Regulator
As a schematic example, see the "Ship mode Option" on the Charger Module sheet.
The drawback is that you add an extra quiescent current when the regulator is ON (few µA -> depend of the input voltage and divider bridge resistor values)
Have a look on the datasheet to optimize symbol pin position.
Replace "5V Boost Regulator" by "5V Buck-Boost Regulator"
Replace "MCU Regulator" by "3.3V MCU Buck-Boost Regulator"
MCU
NTR
The text was updated successfully, but these errors were encountered: