Omit empty fields of State struct #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DimitarPetrov apologies for the late response. I will look into this and get turned around momentarily. |
hebime
previously approved these changes
Sep 26, 2019
|
@DimitarPetrov since this is changing the response and could potentially cause issues for others parsing it, we've decided to include this in V3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where some of the fields are presented in the serialized State without meaningful value.
For example if a component's status is ok there is still fields
first_failure_atandnum_failureswith zero values.Also there are situation where State struct could be used as a DTO for the overall status of the system, in this cases it is useful
nameandcheck_timealso to be omitted since they also will be empty.Also the Fatal field must be presented always so you know if a check is fatal or not. Not only presented for the fatal checks and omitted for all non fatal checks.