Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover Text over Illustrations not obvious enough #66

Open
KatieRussellTBE opened this issue Jan 19, 2018 · 7 comments
Open

Hover Text over Illustrations not obvious enough #66

KatieRussellTBE opened this issue Jan 19, 2018 · 7 comments

Comments

@KatieRussellTBE
Copy link
Collaborator

KatieRussellTBE commented Jan 19, 2018

The text that appears when hovering over the illustration icons on the details page is quite small and easily missed. It also doesn't always match up with the Building Type which is should. They also don't match up with the categories we've provided, e.g. 'Church' should be 'Place of Worship', 'Other' should be 'Other Structure'

There are underscores in the hover text - can these be removed?

Some volunteers have also suggested providing a Key for the illustrations with more explanation.

Volunteer comments:
Could you please explain the small motif to the left of the address?

@jessicasalmon
Copy link
Collaborator

We think that this hover text is a default browser behaviour and only occurs in internet explorer. We've updated the titles of the images so they should match your categorys/have no underscores, so when they do appear they will be correct.

@KatieRussellTBE
Copy link
Collaborator Author

I'm using Firefox and our colleague Aimee is using Chrome, and this happens on both browsers. I've had a play on the site now, and the text when you hover over the illustration is very small and still has underscores in it.

sohilpandya added a commit that referenced this issue Feb 14, 2018
@KatieRussellTBE
Copy link
Collaborator Author

The hover text is still all lower case, and also continues to have underscores in it e.g. 'public_building' should be 'Public Building', 'Home_building' should be 'Home', 'worship' should be 'Place of Worship', 'education_building' should be 'Educational Building'. The text needs to be consistent, and is there any way of increasing the size of the text to make it more obvious?

@jessicasalmon
Copy link
Collaborator

@KatieRussellTBE changing the text content should be done now. Changing the size of the text is out of our control as it's a default browser setting (that's why it appears in some browsers and not others).

@KatieRussellTBE
Copy link
Collaborator Author

Let us know if we should provide you with a full list of the text for the illustration icons. We sent the 8 categories to Noga for creating the illustrations - apologies if this didn't reach you guys too.
If the size can't be changed that's fine, but I assume you can still capitalise letters?

@sohilpandya
Copy link
Contributor

Hey! We've got the categories and capitalised them. Please test this out. 👍

@KatieRussellTBE
Copy link
Collaborator Author

Just checked these and the capitals letters are now there and the underscores removed which is great - thanks!
Currently, the hover text for the 'Home' illustration reads as 'Home Building' - please could this be changed.
Also, I've checked the details page for all the thumbnails, and there is no 'Public House' text anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants