Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML bloat bug #31

Open
picolet21 opened this issue Aug 5, 2023 · 4 comments
Open

XML bloat bug #31

picolet21 opened this issue Aug 5, 2023 · 4 comments

Comments

@picolet21
Copy link

Hello

I found a bug in the XML export of v1.1.3.2.
The XML content is not read and the manifest content is exported at the end.

So the xml gets bloated every time I start the game.
The content of xml is also not reflected in the position name.

The same phenomenon was confirmed in v1.1.3.1.

please confirm.

@IDontHaveIdea
Copy link
Collaborator

IDontHaveIdea commented Aug 5, 2023

Hi,

Can you post the game logs? And what game KK or KKS.

@picolet21
Copy link
Author

sorry. The game is Sunshine.
However, a similar phenomenon occurred in KK.

I have attached the bloated XML file and the log when the phenomenon occurred.

output_log_KK1.txt
output_log_KKS1.txt
names-kpluganim.xml

An internal error occurs if the XML file does not exist.
And the positions doesn't seem to be reflected in the game either.

output_log_KKS2.txt

Please check the log.

@IDontHaveIdea
Copy link
Collaborator

IDontHaveIdea commented Aug 6, 2023

Hi good day,

Try these:

  • No xml file should create a new one ready for translation.
  • xml file present should read translations and add any new animation entry that needs translation. It should not override any animation already in the xml file it will only add the missing ones.

AnimationLoader.KoikatsuSunshine_v1.1.3.2.zip
AnimationLoader.Koikatu_v1.1.3.2.zip

The file versions are the same until an official release.

Thanks for reporting the problem I was thinking that nobody was using this.

@picolet21
Copy link
Author

thank you very much!

Both KK and KKS worked well!
I didn't get an internal error when the file doesn't exist, nor did the XML bloat.

I publish the translated XML for the Japanese community, so I'm very happy to see this feature in action.
I'm looking forward to the official release.

Sincerely thank.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants