Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable overflow at item lookat #128

Open
estralis opened this issue Apr 13, 2021 · 2 comments
Open

Variable overflow at item lookat #128

estralis opened this issue Apr 13, 2021 · 2 comments

Comments

@estralis
Copy link
Member

(To be completed)

Description

Screenshot 2021-04-13 170652

Code links
https://github.com/Illarion-eV/Illarion-Content/blob/d5c8f87d791511075218a120091b6ec989cc39e1/base/lookat.lua line 255 + 166

https://github.com/Illarion-eV/Illarion-Java/blob/develop/illaclient/src/main/java/illarion/client/gui/controller/game/TooltipHandler.java line 198

Related Mantis Tickets
https://illarion.org/mantis/view.php?id=9135 (similar overflow for weight)

@estralis
Copy link
Member Author

Input Kerruan: For weight all combinations where stacksize * weight > 65535 (max uint16_t) are a problem, thats often the case for item stacks > 655 (coal, buckets, vase etc) for example. For price its a problem if stacksize * price > 214748364(max uint32_t /20), Vase should work until 7158 correctly I think.

@estralis
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant