-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapter 9 / Python: any_tuple_load #119
Comments
The index argument of any_tuple_load is required (statically) to be an integer. So no ValueOf's are needed. I've updated the type checker to make this clear. |
Regarding any_len, why not untagged? Because it's difficult to give a type to the result of untagging the tuple. I use to do that, but it was a pain. Why return an untagged integer? Because when we use any_len inside of the translation of any_tuple_load in the reveal_casts pass, we want the integer for purposes of doing the bounds check. |
Regarding any_tuple_load translating to any_tuple_load... the later should be renamed to unsafe_any_tuple_load. |
What was the inconsistency regarding the typing of any_tuple_load? |
I see that the cast insertion for subscript was broken in the book, and too limited in the implementation. I've fixed that now. Sorry for these bugs! |
The translation of any_tuple_load at the end of section 9.5 is weird.
The text was updated successfully, but these errors were encountered: