Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (timeit_debug) #1528

Closed
wants to merge 1 commit into from
Closed

Conversation

MazenAli
Copy link

  • add timeit_debug_enabled for TimerOutputs
  • update CodeTiming.md

Description

This would fix the issue with TimerOutputs timeit_debug.
The output of profilers is too verbose and a pain to interpret, I found this more useful (see also screenshot).

Fixes #1526

Screenshot 2024-09-11 at 12 03 19

- add timeit_debug_enabled for TimerOutputs
- update CodeTiming.md
@mtfishman
Copy link
Member

mtfishman commented Sep 12, 2024

See my comment here: #1526 (comment). I would prefer to remove TimerOutputs from the codebase, and users can instead either use profiling or dev the package and add their own timer annotations.

This was never meant to be a user-facing feature, we only added timers for internal development purposes. I think it is a bad idea to make timers user facing because it is just another feature we have to upkeep and users will rely on, and users will inevitably want new timers added for their own purposes so it will be an endless game of supporting the current timers as we refactor the codebase (see ITensorTDVP.jl/ITensorMPS.jl/ITensorNetworks.jl where we are rewriting and generalizing DMRG in various ways), adding new timers, or turning down requests for new timers to be added.

EDIT: I also remember seeing some performance issue with TimerOutputs.jl, I think it caused some type instability, though maybe that has been fixed at this point or I am misremembering.

@mtfishman mtfishman closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ITensors] [ENCHANCEMENT] Remove TimerOutputs.jl as a dependency
2 participants