You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm trying to extend with more components (more api-resources) to check on and see a need for a change in the api.
The need I had was to add some checks on some resources for cert-manager.io. This does not work with your current implementation.
I had to change in the mapping file and an addition to build_url to supply the apiResource-name.
My understanding is that the URL for a CRD is "server:someport/apis/".
so for some CRDs in cert-manager.io it uses apiResource-name "cert-manager.io/v1" and the url becomes "server:someport/apis/cert-manager.io/v1".
I don't know from which version of kubernetes this is used but it could be possible to remove the is_core value in mappings. Unless you want to support the older URL.
If I find the time I may be able to send a PR but this is pretty simple changes of the mappings file and it's usage.
The text was updated successfully, but these errors were encountered:
Thanks for this check.
I'm trying to extend with more components (more api-resources) to check on and see a need for a change in the api.
The need I had was to add some checks on some resources for cert-manager.io. This does not work with your current implementation.
I had to change in the mapping file and an addition to build_url to supply the apiResource-name.
My understanding is that the URL for a CRD is "server:someport/apis/".
so for some CRDs in cert-manager.io it uses apiResource-name "cert-manager.io/v1" and the url becomes "server:someport/apis/cert-manager.io/v1".
I don't know from which version of kubernetes this is used but it could be possible to remove the is_core value in mappings. Unless you want to support the older URL.
If I find the time I may be able to send a PR but this is pretty simple changes of the mappings file and it's usage.
The text was updated successfully, but these errors were encountered: