Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in API för components #59

Open
rogermartensson opened this issue Oct 20, 2022 · 0 comments
Open

Change in API för components #59

rogermartensson opened this issue Oct 20, 2022 · 0 comments

Comments

@rogermartensson
Copy link

Thanks for this check.

I'm trying to extend with more components (more api-resources) to check on and see a need for a change in the api.

The need I had was to add some checks on some resources for cert-manager.io. This does not work with your current implementation.
I had to change in the mapping file and an addition to build_url to supply the apiResource-name.

My understanding is that the URL for a CRD is "server:someport/apis/".
so for some CRDs in cert-manager.io it uses apiResource-name "cert-manager.io/v1" and the url becomes "server:someport/apis/cert-manager.io/v1".

I don't know from which version of kubernetes this is used but it could be possible to remove the is_core value in mappings. Unless you want to support the older URL.

If I find the time I may be able to send a PR but this is pretty simple changes of the mappings file and it's usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant