-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cookie consent example #10320
base: develop
Are you sure you want to change the base?
Add cookie consent example #10320
Conversation
Bah. Git is hard. I made dsd-sztaki-hu#3 but it looks weird. 🤷 @beepsoft I can't push to your branch. Can you please merge the latest from "develop" into this pull request and then look at (and hopefully) adopt these two commits? Thanks. |
@beepsoft can you please check out my comment above? I also pinged you in the thread on Zulip: https://dataverse.zulipchat.com/#narrow/channel/379673-dev/topic/Cookie.20consent.20best.20practices/near/484383437 . Thanks! ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks, @beepsoft!
What this PR does / why we need it:
Adds a description how to have a cookie consent banner in a Dataverse installation to allow users to opt out of, for example, from Google Analytics tracking to comply with GDPR. Implementation is based on this chat:
https://dataverse.zulipchat.com/#narrow/stream/379673-dev/topic/Cookie.20consent.20best.20practices
Special notes for your reviewer:
I'm not sure about the formatting as I just used IntelliJ's builtin .rst support, which doesn't show code blocks and images. So, please review and adjust it to match the Dataverse documentation standards.
Suggestions on how to test this:
You should follow the instructions to see if the installation and configuration steps work.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
It displays a cookie consent overlay (the layout of which can be configure from javascript and css), which is independent of any other Dataverse UI code. The documentation includes a screenshot of the cookie consent popup displayed.
Additional documentation:
https://cookieconsent.orestbida.com/
Preview at https://dataverse-guide--10320.org.readthedocs.build/en/10320/installation/config.html#adding-cookie-consent-for-gdpr-etc