Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookie consent example #10320

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

beepsoft
Copy link
Contributor

@beepsoft beepsoft commented Feb 14, 2024

What this PR does / why we need it:

Adds a description how to have a cookie consent banner in a Dataverse installation to allow users to opt out of, for example, from Google Analytics tracking to comply with GDPR. Implementation is based on this chat:

https://dataverse.zulipchat.com/#narrow/stream/379673-dev/topic/Cookie.20consent.20best.20practices

Special notes for your reviewer:

I'm not sure about the formatting as I just used IntelliJ's builtin .rst support, which doesn't show code blocks and images. So, please review and adjust it to match the Dataverse documentation standards.

Suggestions on how to test this:

You should follow the instructions to see if the installation and configuration steps work.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

It displays a cookie consent overlay (the layout of which can be configure from javascript and css), which is independent of any other Dataverse UI code. The documentation includes a screenshot of the cookie consent popup displayed.

cookie-consent-example

Additional documentation:

https://cookieconsent.orestbida.com/

Preview at https://dataverse-guide--10320.org.readthedocs.build/en/10320/installation/config.html#adding-cookie-consent-for-gdpr-etc

@pdurbin pdurbin added the Size: 0.5 A percentage of a sprint. 0.35 hours label Feb 28, 2024
@pdurbin
Copy link
Member

pdurbin commented Sep 27, 2024

Bah. Git is hard. I made dsd-sztaki-hu#3 but it looks weird. 🤷

@beepsoft I can't push to your branch. Can you please merge the latest from "develop" into this pull request and then look at (and hopefully) adopt these two commits?

Thanks.

@pdurbin pdurbin added the Type: Feature a feature request label Oct 9, 2024
@cmbz cmbz added the FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) label Nov 22, 2024
@pdurbin
Copy link
Member

pdurbin commented Nov 25, 2024

@beepsoft can you please check out my comment above? I also pinged you in the thread on Zulip: https://dataverse.zulipchat.com/#narrow/channel/379673-dev/topic/Cookie.20consent.20best.20practices/near/484383437 . Thanks! ❤️

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, @beepsoft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) Size: 0.5 A percentage of a sprint. 0.35 hours Type: Feature a feature request
Projects
Status: Ready for QA ⏩
Development

Successfully merging this pull request may close these issues.

3 participants