Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share Collection and Share Dataset features #553

Open
g-saracca opened this issue Nov 20, 2024 · 2 comments · May be fixed by #554
Open

Share Collection and Share Dataset features #553

g-saracca opened this issue Nov 20, 2024 · 2 comments · May be fixed by #554
Labels
FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) GREI Re-arch GREI re-architecture-related Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA: Collection Page SPA: Edit Dataset Page SPA.Q4.8 Collection Page: Share SPA

Comments

@g-saracca
Copy link
Contributor

g-saracca commented Nov 20, 2024 •
edited
Loading

The goal is to replicate the Share feature on the Collection Page and Dataset Page, supporting the same sharing channel options as in JSF.
@g-saracca g-saracca added Size: 10 A percentage of a sprint. 7 hours. SPA: Collection Page SPA Original size: 10 SPA.Q4.8 Collection Page: Share labels Nov 20, 2024
@g-saracca g-saracca moved this to In Progress 💻 in IQSS Dataverse Project Nov 20, 2024
@g-saracca g-saracca self-assigned this Nov 20, 2024
@g-saracca g-saracca added FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) GREI Re-arch GREI re-architecture-related labels Nov 20, 2024
@pdurbin
Copy link
Member

pdurbin commented Nov 20, 2024

Out of curiosity, are we keeping the same order? Of the three we have now I sort of feel like LinkedIn should be first. It's more professional than Twitter/X (in JSF it's only shown as Twitter, by the way) or Facebook.

Screenshot 2024-11-20 at 10 16 07 AM

Also, the hover text is "FaceBook" but we should use "Facebook" instead.

@g-saracca
Copy link
Contributor Author

Hi @pdurbin, sounds good to me, will put LinkedIn first and also change twitter icon for X one. Will share with you the component storybook once is finished so you can take a look.

@g-saracca g-saracca changed the title Collection page: Share Share Collection and Share Dataset features Nov 21, 2024
@g-saracca g-saracca linked a pull request Nov 21, 2024 that will close this issue
Open
@cmbz cmbz added the FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) label Nov 21, 2024
@g-saracca g-saracca removed their assignment Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) GREI Re-arch GREI re-architecture-related Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA: Collection Page SPA: Edit Dataset Page SPA.Q4.8 Collection Page: Share SPA
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Share Collection and Share Dataset features IQSS/dataverse-frontend
3 participants
@pdurbin @cmbz @g-saracca