Feature/492 publish dataset with compare versions #551
+580
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ajorVersionUpdate param to PublishDatasetModal.tsx
ekraffmiller
added
FY25 Sprint 10
g-saracca
reviewed
Nov 22, 2024
src/dataset/infrastructure/repositories/DatasetJSDataverseRepository.ts
Outdated
Show resolved
Hide resolved
tests/component/dataset/infrastructure/mappers/JSDatasetMapper.spec.ts
Outdated
Show resolved
Hide resolved
|
thanks @g-saracca, ready to review now |
g-saracca
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Great job @ekraffmiller , approving!
Just one comment, you are mapping the js-dataverse versionDiff in toDatasetVersionDiff but not changing any property, maybe we don't need the mapper at all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a use case for comparing dataset versions, and uses it to add a property to the Dataset object, a boolean that indicates whether the next version should be a major or minor version update.
The boolean requiresMajorVersionUpdate will be true if the draft contains added, removed or replaced files. If this boolean is true, then the PublishDatasetModal will include help text describing the major version update.
Which issue(s) this PR closes:
Special notes for your reviewer:
The dataverse API hasn't been merged yet, so to run locally, use the PR image:
./run-env.sh 10888-add-api-for-comparing-dataset-versionsSuggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation:
Add a waiting tag because this Dataverse PR IQSS/dataverse#10945 needs to be merged for e2e tests to work